Skip to content

Fix pcre out-of-bounds when using closing symbols as opening delimiter #12946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix pcre out-of-bounds when using closing symbols as opening delimiter #12946

merged 1 commit into from
Dec 12, 2023

Conversation

@iluuu1994
Copy link
Member

Apparently we support using closing symbols )]}> as opening and closing delimiters.

Fixes oss-fuzz #65021

@iluuu1994
Fix pcre out-of-bounds when using closing symbols as opening delimiter
90dc05a 
Apparently we support using closing symbols )]}> as opening and closing
delimiters.

Fixes oss-fuzz #65021
@iluuu1994 iluuu1994 requested a review from nielsdos December 12, 2023 19:40
nielsdos
nielsdos approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... By adding 5 we "shift" from the opening symbol to closing symbol. Which is why we need to repeat the closing part. It's just kind of a weird way of doing it.
Thanks for fixing.

@iluuu1994 iluuu1994 merged commit be46545 into php:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees

No one assigned

Labels

Extension: pcre

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iluuu1994 @nielsdos