Fix issues related to libxml2 2.12.0 #12802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
libxml2.12
branch
2 times, most recently
from
9c4efa9 to
0d142aa
Compare
This otherwise switches to UTF-8 on libxml2 2.12.0
We can't fully get rid of the parser globals as there are still APIs that implicitly use them.
Girgias
reviewed
Nov 28, 2023
Comment on lines
203
to
204
| // TODO: re-enable this once this is figured out: https://gitlab.gnome.org/GNOME/libxml2/-/issues/634 | ||
| //var_dump($dom1->isEqualNode($dom1Clone)); |
There was a problem hiding this comment.
Maybe XFAIL this test rather than comment the line? Or split this seemingly large test into multiples and XFAIL just that? Anyway I am fine with this just being commented out
There was a problem hiding this comment.
The libxml maintainer fixed this sooner than expected. The fix will be in 2.12.2. So I'll just mark this test as XFAIL for 2.12.0 & 2.12.1.
Girgias
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to backport the test changes once this is merged to master. The encoding change only needs to happen on master because only master contains that code.