[Reflection] Update return types in some stubs #12502
Conversation
phansys
force-pushed
the
reflection_named_type
branch
2 times, most recently
from
8a778b4 to
b33ad3a
Compare
phansys
force-pushed
the
reflection_named_type
branch
from
b33ad3a to
0bd5391
Compare
phansys
changed the title
ReflectionProperty::getType()
phansys
force-pushed
the
reflection_named_type
branch
from
0bd5391 to
7af6b70
Compare
|
|
||
| /** @tentative-return-type */ | ||
| public function getReturnType(): ?ReflectionType {} | ||
| public function getReturnType(): ReflectionNamedType|ReflectionUnionType|ReflectionIntersectionType|null {} |
There was a problem hiding this comment.
Hmmm.. I'm not sure this is the best way to solve your original issue. If we happened to add a new ReflectionType instance then people extending ReflectionFunctionAbstract would have to adapt their return types accordingly. And it is not even going to be possible in a BC way since the class won't be available in older PHP versions.
Please also note that you have to use ./build/gen_stub.php to generate the C header code which we use.
There was a problem hiding this comment.
Yeah I don't understand the point of this change. ReflectionType exists as a generic interface for anything that can return a type, so making the return type concrete is just... weird.
There was a problem hiding this comment.
I understand the point.
My motivation was to avoid the check for the availability of the getName() method, which is provided by the ReflectionNamedType. IE:
$reflectionProperty = new \ReflectionProperty($object, 'foo');
$reflectionType = $reflectionProperty->getType();
assert($reflectionType instanceof \ReflectionNamedType);
$type = $reflectionType->getName();But, in view of the current proposal (where ReflectionUnionType and ReflectionUnionType are possible types), I guess this is not a feasible solution.
Thank you so much for your feedback.
3 participants
No description provided.