Fix #50713: openssl_pkcs7_verify() may ignore untrusted CAs #12499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
openssl_pkcs7_verify_signers_certs
branch
from
cfbb49e to
415507d
Compare
ramsey
pushed a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signers were not correctly retrieved if additional (untrusted) certs were used as they were not used for retrieving the signers. The main part of this work was to create a properly verified certs tests. The sign operation does not include the cert in envelope so it is passed explicitly (main use case for untrusted certs). Before the function would return -1 and empty signers file. This is now fixed.