Skip to content

Fix the incorrect data type of float values in pdo_pgsql query results #12476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix the incorrect data type of float values in pdo_pgsql query results #12476

wants to merge 1 commit into from

Conversation

@Yurunsoft
Copy link
Contributor

No description provided.

@Yurunsoft Yurunsoft requested a review from devnexen as a code owner October 19, 2023 03:15
@Yurunsoft Yurunsoft changed the title Fix the incorrect data type of float values in PDO query results Fix the incorrect data type of float values in pdo_pgsql query results Oct 19, 2023
devnexen
devnexen reviewed Oct 19, 2023
View reviewed changes
@devnexen
Copy link
Member

Issue seems legit on the Windows CI instance otherwise.

mvorisek
mvorisek reviewed Oct 20, 2023
View reviewed changes
@devnexen
Copy link
Member

Thanks, whenever you can please squash your commits into 1.

@Yurunsoft
Copy link
Contributor Author

Thanks, whenever you can please squash your commits into 1.

Done.

devnexen
devnexen approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition ! I ll commit it a bit later.

@devnexen devnexen closed this in 6d10a69 Oct 20, 2023
@jonathan-shahen
Copy link

jonathan-shahen commented Mar 21, 2024 •
edited
Loading

As of 8.3 this code is still not merge, but it does exists in the master branch.
When is this code scheduled to be included in the next release?
It was merged 5 months ago according to git blame.

image

I ask because I am debating creating a custom fix for this (if this is scheduled for 8.4 release) or waiting a month it is available then (8.3.x release).

@devnexen
Copy link
Member

At the time, PHP 8.3 already reached the feature freeze status, it will be present for 8.4 on november indeed.

devnexen added a commit to devnexen/php-src that referenced this pull request Sep 9, 2024
@devnexen
Fix phpGH-15810: Forgotten UPGRADING entry for Pdo_Pgsql::query.
c176f3d 
ref: phpGH-12476
@devnexen devnexen mentioned this pull request Sep 9, 2024
Merged
devnexen added a commit to devnexen/php-src that referenced this pull request Sep 9, 2024
@devnexen
Fix phpGH-15810: Forgotten UPGRADING entry for Pdo_Pgsql::query.
cea33b8 
ref: phpGH-12476
devnexen added a commit that referenced this pull request Sep 9, 2024
@devnexen
[skip ci] Fix GH-15810: Forgotten UPGRADING entry for Pdo_Pgsql::quer…
b5c378c 
…y. (#15811)

ref: GH-12476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen devnexen approved these changes

+1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Extension: pdo_pgsql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yurunsoft @devnexen @jonathan-shahen @mvorisek