Skip to content

Conversation

@nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 8, 2023

No description provided.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we wouldn't care about BC I would say to use a ValueError instead.

But this is a nice improvement.

@nielsdos nielsdos merged commit 009d48d into php:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants