Implement request #68325: parse huge option for xml_parser_create #12256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Sep 20, 2023
nielsdos
force-pushed
the
xml-parse-huge
branch
from
31b17b4 to
931f089
Compare
MaxSem
reviewed
Sep 22, 2023
nielsdos
force-pushed
the
xml-parse-huge
branch
from
931f089 to
220cdd5
Compare
nielsdos
force-pushed
the
xml-parse-huge
branch
from
220cdd5 to
ea7d448
Compare
|
RFC was accepted. Rebased + added UPGRADING. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=68325
RFC: https://wiki.php.net/rfc/xml_option_parse_huge
This issue is work-aroundable with xml_parse by using chunked parsing. However, that's cumbersome when it's already in memory. Also, that doesn't work for xml_parse_into_struct as it doesn't really support chunked parsing.
Reminder for self: as a follow up, convert int option fields to booleans.
I'll probably need to send an email to internals for this, I'll do that sometime soon.