Skip to content

Fix memory leak with failed SQLPrepare #12095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix memory leak with failed SQLPrepare #12095

wants to merge 1 commit into from

Conversation

@NattyNarwhal
Copy link
Member

If odbc_prepare fails in SQLPrepare, then it neglects to free result like the other codepaths that exit early.

Girgias
Girgias approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be merged into 8.1 as it is a bug fix.

@Girgias Girgias closed this in a022ec5 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: odbc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NattyNarwhal @Girgias