Skip to content

ext/spl: Fix various ArrayObject bugs #12037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ext/spl: Fix various ArrayObject bugs #12037

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01d4365
ext/spl: Fix no Error being thrown when appending ArrayObjey with obj…
Girgias Aug 22, 2023
1534af4
ext/spl: Fix unnecessible value written when using null as key
Girgias Aug 22, 2023
1f7c794
Fix no dynamic prop warning + typed prop
Girgias Aug 22, 2023
79211f6
ext/spl: Fix various bugs relating to property access
Girgias Aug 23, 2023
c320450
Use property guard instead of custom write_property logic
Girgias Aug 30, 2023
c949efd
Naming restriction applies (except for integers)
Girgias Sep 17, 2023
20f99d0
Remove now invalid comment
Girgias Nov 16, 2023
7e46992
Allow overriding the behaviour of appending operator via append()
Girgias Dec 1, 2023
127652f
UPGRADING
Girgias Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Naming restriction applies (except for integers)
  • Loading branch information
@Girgias
Girgias committed Dec 1, 2023
commit c949efd05e5752398fac7e2242ee18498ef04bf3
19 changes: 3 additions & 16 deletions ext/standard/tests/class_object/get_object_vars_variation_005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,40 +7,27 @@ get_object_vars() no-declared/declared discrepancies
class Test {
public $prop;
}

// Using ArrayObject here to get around property name restrictions

$obj = new stdClass;
$ao = new ArrayObject($obj);
$ao["\0A\0b"] = 42;
$ao["\0*\0b"] = 24;
$ao[12] = 6;
var_dump(get_object_vars($obj));

$obj = new Test;
$ao = new ArrayObject($obj);
$ao["\0A\0b"] = 42;
$ao["\0*\0b"] = 24;
$ao[12] = 6;
var_dump(get_object_vars($obj));

?>
--EXPECTF--
array(3) {
["%0A%0b"]=>
int(42)
["%0*%0b"]=>
int(24)
--EXPECT--
array(1) {
[12]=>
int(6)
}
array(4) {
array(2) {
["prop"]=>
NULL
["%0A%0b"]=>
int(42)
["%0*%0b"]=>
int(24)
[12]=>
int(6)
}