[skip ci] Mark test as XFAIL due to LSAN bug on Clang 14 #12018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Aug 22, 2023
sapi/cli/tests/ext_loading.phpt
Outdated
| @@ -7,6 +7,8 @@ if (!file_exists($extDir . '/opcache.so') && !file_exists($extDir . '/php_opcach | |||
| die('skip Opcache shared object not found in extension_dir'); | |||
| } | |||
| ?> | |||
| --XFAIL-- | |||
| LSAN bug on Clang 14 marks this as leaking | |||
There was a problem hiding this comment.
Please move this to skipif and only xfail if we're actually using asan.
iluuu1994
reviewed
Aug 22, 2023
sapi/cli/tests/ext_loading.phpt
Outdated
| @@ -7,6 +7,8 @@ if (!file_exists($extDir . '/opcache.so') && !file_exists($extDir . '/php_opcach | |||
| die('skip Opcache shared object not found in extension_dir'); | |||
| } | |||
| ?> | |||
| --SKIPIF-- | |||
| <?php if (getenv('SKIP_ASAN')) die('xfail LSAN bug on Clang 14 marks this as leaking'); ?> | |||
There was a problem hiding this comment.
Oh, and also, it doesn't report a leak, it crashes.
There was a problem hiding this comment.
Oh, and also use xleak please 😄 Sorry for the fragmented comments.
There was a problem hiding this comment.
Right, also we have trailing whitespaces in the test output so... changed that too
Change formatting of output to not have trailing whitespaces
iluuu1994
approved these changes
Aug 22, 2023
Yeah that would be ideal :[ |
|
Can be reverted in #12034 😄 (or the skipif removed rather) |
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 24, 2023
This is due to apparently some combination of glibc and Clang 14 which we are unfortunately hitting
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 24, 2023
This is due to apparently some combination of glibc and Clang 14 which we are unfortunately hitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.