Refactor attribution for code portions in ext/random via README.REDIST.BINS #11998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
added
Quickfix
Category: Documentation
TimWolla
reviewed
Aug 20, 2023
There was a problem hiding this comment.
The change clearly is correct, but:
- Should this be applied to PHP 8.2?
- PHP 8.2: Do we need also need entries for Xoshiro256** (CC-0) and PCG (apparently Apache)?
- PHP 8.3: Do we need an entry for γ-section (scientific paper, see )
php-src/ext/random/gammasection.c
Lines 27 to 32 in e6627cc
/cc @zeriyoshi
petk
force-pushed
the
patch-redist-bins
branch
from
177fd50 to
885db38
Compare
|
Updated and added. For the gammasection.c we can add it in a separate PR. This probably then needs to be shortly noted in NEWS for PHP-8.2. I've changed the targeted branch now also. |
This updates and adds attribution and license info about portions of code used in ext/random: - Portions of mt19937 code - Portions of xoshiro256 code - Portions of pcgoneseq128xslrr64 code
petk
force-pushed
the
patch-redist-bins
branch
from
885db38 to
c6e9f8e
Compare
TimWolla
reviewed
Aug 21, 2023
petk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates README.REDIST.BINS from ext/standard/rand to current ext/random extension. Just to have it synced.