Bcmath pow improvements #11993
Closed
Bcmath pow improvements #11993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix squaring for small numbers Fix the function bc_quare Improve indentation
|
I'm closing this PR as I don't intend to make any new changes to this extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the BCMath function
bcpow.We don't need to perform usual multiplication when we square them. I implemented faster version of multiplication of the same number.
Approach with the function
bc_squareis faster about 3,4% in one of my benchmarks when I runbcpowof 10000 numbers with the exponent of 16. I suppose for bigger numbers it's more meaningful change.