add ZipArchive::LENGTH_TO_END and ZipArchive::LENGTH_UNCHECKED constants #11811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Jul 28, 2023
ext/zip/php_zip.stub.php
Outdated
| * @var int | ||
| * @cvalue ZIP_LENGTH_TO_END | ||
| */ | ||
| public const LENGTH_TO_END = UNKNOWN; |
There was a problem hiding this comment.
you can now declare the constant types :) P.S.: Would you be OK to convert all ZipArchive class constants to typed?
There was a problem hiding this comment.
I prefer to not, as same code is also used for older PHP versions, and don't want to much diff.
There was a problem hiding this comment.
Btw, compat macro works, so done
Also in pecl pierrejoye/php_zip@f8abd19
ext/zip/php_zip.stub.php
Outdated
| /** | ||
| * @var int | ||
| */ | ||
| public const LENGTH_TO_END = 0; |
There was a problem hiding this comment.
please avoid declaring the same constant "twice" when possible as doing so may introduce problems to the generation of the manual AFAIR. E.g. You could conditionally declare ZIP_LENGTH_TO_END with the default value in the header file.
|
LGTM |
kocsismate
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZipArchive::LENGTH_TO_ENDis always defined as 0ZipArchive::LENGTH_UNCHECKEDwill be defined with libzip 1.10.1 planned for AugustAlready in pecl/zip, will be in version 1.22.2 planned to be released immediately after libzip
I think this is better to have in 8.3 before RC