Fix open_basedir leak #11780
Closed
Fix open_basedir leak #11780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes oss-fuzz #60741
iluuu1994
referenced
this pull request
Jul 25, 2023
Girgias
reviewed
Jul 25, 2023
| @@ -80,6 +80,7 @@ struct _php_core_globals { | |||
| char *user_dir; | |||
| char *include_path; | |||
| char *open_basedir; | |||
| bool open_basedir_modified; | |||
There was a problem hiding this comment.
I know @nielsdos did some struct packing at one time, but there was also one case where it wasn't super worth it to do it compared to keeping the relevant bits nearby. Might have been the globals struct
There was a problem hiding this comment.
Yeah. I prefer keeping related globals together, as it's easier to understand but also potentially improves cache locality. I'm not going to die on a hill for this though.
There was a problem hiding this comment.
I indeed did a bit of struct packing here too. When I did it I made sure that fields that were in the same cacheline were still in the same line after reordering. However, packing is not important here, this is fine as-is imo.
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Jul 26, 2023
Fixes oss-fuzz #60741 Closes phpGH-11780
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Fixes oss-fuzz #60741 Closes phpGH-11780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oss-fuzz #60741