Skip to content

Fix various namespace prefix conflict resolution bugs #11777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix various namespace prefix conflict resolution bugs #11777

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f08cda
Add regression tests
nielsdos Jul 23, 2023
8965426
Fix various namespace prefix conflict resolution bugs
nielsdos Jul 23, 2023
12c1447
Address review comments and split tests
nielsdos Aug 5, 2023
f61b77f
Modify test to workaround bug 80927
nielsdos Aug 5, 2023
650917e
Restore test to original
nielsdos Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modify test to workaround bug 80927
  • Loading branch information
@nielsdos
nielsdos committed Aug 14, 2023
commit f61b77f500b92493027953c9367665fa23fb030a
9 changes: 4 additions & 5 deletions ext/dom/tests/delayed_freeing/namespace_definition_crash_in_attribute.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ var_dump($child_attr2->namespaceURI);
var_dump($attr3->textContent);
var_dump($attr3->namespaceURI);

$doc->documentElement->remove();

unset($child_attr1);
unset($child_attr2);
var_dump($attr3->namespaceURI);
Expand All @@ -39,15 +37,16 @@ echo $doc->saveXML($attr3->parentNode), "\n";
?>
--EXPECT--
<?xml version="1.0"?>
<container xmlns="some:ns2"><child xmlns="some:ns" hello="hello content 2" hello2=""><childcontainer hello=""/></child></container>
<container xmlns:default="some:ns2" xmlns:default1="some:ns"><child xmlns="some:ns" default:hello="hello content 2" hello2=""><childcontainer default1:hello=""/></child></container>
<?xml version="1.0"?>
<container xmlns="some:ns2"/>
<container xmlns:default="some:ns2" xmlns:default1="some:ns"/>
string(15) "hello content 2"
string(0) ""
string(8) "some:ns2"
NULL
string(0) ""
string(7) "some:ns"
string(7) "some:ns"
hello=""
default1:hello=""
<?xml version="1.0"?>
<container xmlns:default="some:ns2" xmlns:default1="some:ns"/>