Skip to content

Add some typed class consts #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add some typed class consts #11721

merged 2 commits into from
Jul 18, 2023

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Jul 17, 2023 •
edited
Loading

ext/ffi ones are straightforward since they are in final classes. SNMP class constants are debatable, but I think it shouldn't cause a big issue.

@kocsismate kocsismate requested a review from dstogov as a code owner July 17, 2023 06:39
Girgias
Girgias approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, this needs an UPGRADING entry for SNMP

@kocsismate kocsismate merged commit 1dcac96 into php:master Jul 18, 2023
@kocsismate kocsismate deleted the add-typed-class-consts branch July 18, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees

No one assigned

Labels

Extension: ffi Extension: snmp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kocsismate @Girgias