Skip to content

Fix performance for Bcmath numbers with trailing zeros #11641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Fix performance for Bcmath numbers with trailing zeros #11641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7124c53
Adjust bc_num to number without trailing zeros
jorgsowa Jul 6, 2023
0653132
Improve tests for bcpow with zero
jorgsowa Jul 7, 2023
ec994a3
Fixed tests for 32bits systems
jorgsowa Jul 8, 2023
f55eab1
Fixed test case for maximum exponent for int to lower than max
jorgsowa Jul 8, 2023
d63ba2f
Fix bcmath tests for number zero
jorgsowa Jul 8, 2023
d812639
Remove unused ZEND_STACK_GROWS_DOWNWARDS constant (#11762)
petk Jul 22, 2023
8fbbfd6
zend call stack fix freebsd code path. (#11766)
devnexen Jul 23, 2023
5d6d66b
zend vm savee registers support for riscv 64. (#11773)
devnexen Jul 24, 2023
c6202fc
Fixed incorrect QM_ASSIGN elimination
dstogov Jul 24, 2023
f8f3280
Use xmlSetNsProp when possible to prevent parsing the name
nielsdos Jul 22, 2023
1bd964c
Remove useless readonly checks
nielsdos Jul 22, 2023
a808b32
Simplify configuration getters (#11778)
nielsdos Jul 24, 2023
39d7258
Refactor BCMath bundledlib and extension (#10774)
Girgias Jul 24, 2023
acf1bf7
[skip ci] Add myself to CODEOWNER for BCMath extension
Girgias Jul 24, 2023
ac1fc0e
Fix DOMEntity field getter bugs
nielsdos Jul 23, 2023
6da01ce
Fix incorrect attribute existence check in DOMElement::setAttributeNo…
nielsdos Jul 23, 2023
058cfa5
Fix DOMCharacterData::replaceWith() with itself
nielsdos Jul 22, 2023
05b4555
Fix empty argument cases for DOMParentNode methods
nielsdos Jul 22, 2023
095be3e
[skip ci] Don't render zend_vm_handlers.h in PRs
iluuu1994 Jul 25, 2023
96b77f6
Fix open_basedir leak
iluuu1994 Jul 24, 2023
716f6b4
Call cast_object handler from get_properties_for
iluuu1994 Jun 30, 2023
2372bf2
CS
derickr Jul 19, 2023
7ecb398
Make the new DatePeriod::createFromISO8601String method emit DateTime…
derickr Jul 19, 2023
00163a3
Adjust bc_num to number without trailing zeros
jorgsowa Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust bc_num to number without trailing zeros
  • Loading branch information
@jorgsowa
jorgsowa committed Jul 26, 2023
commit 00163a3ec39b4e704210b57baf5455302d40e36a
2 changes: 1 addition & 1 deletion ext/bcmath/tests/bcpow_large_numbers.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,4 @@ Number "0.1322135476547459213732911312" (scale 10)

Number "-0.123912932193769965476541321" (scale 10)
-0.123912932193769965476541321 ** 252 = 0.0000000000
-0.123912932193769965476541321 ** -112 = 372337687215014577843846097845819604950292238064034167723169672020440891758727112526694844172394015451.7302535898
-0.123912932193769965476541321 ** -112 = 372337687215014577843846097845819604950292238064034167723169672020440891758727112526694844172394015451.7302535898
58 changes: 57 additions & 1 deletion ext/bcmath/tests/bcpow_zero.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ bcmath.scale=0
<?php
require(__DIR__ . "/run_bcmath_tests_function.inc");

$exponents = ["0", "-0", "1", "1128321638"];
$exponents = ["0", "-0", "1", "3128321638211"];
$baseNumbers = [
"0.00",
"-0.00",
Expand All @@ -26,12 +26,17 @@ Number "0.00" (scale 0)
0.00 ** 0 = 1
0.00 ** -0 = 1
0.00 ** 1 = 0
<<<<<<< HEAD
0.00 ** 1128321638 = 0
=======
0.00 ** 3128321638211 = 0
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "-0.00" (scale 0)
-0.00 ** 0 = 1
-0.00 ** -0 = 1
-0.00 ** 1 = 0
<<<<<<< HEAD
-0.00 ** 1128321638 = 0

Number "0.000000000000000000000000" (scale 0)
Expand All @@ -45,29 +50,57 @@ Number "-0.000000000000000000000000" (scale 0)
-0.000000000000000000000000 ** -0 = 1
-0.000000000000000000000000 ** 1 = 0
-0.000000000000000000000000 ** 1128321638 = 0
=======
-0.00 ** 3128321638211 = 0
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "-0" (scale 0)
-0 ** 0 = 1
-0 ** -0 = 1
-0 ** 1 = 0
<<<<<<< HEAD
-0 ** 1128321638 = 0
=======
-0 ** 3128321638211 = 0
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "0" (scale 0)
0 ** 0 = 1
0 ** -0 = 1
0 ** 1 = 0
<<<<<<< HEAD
0 ** 1128321638 = 0
=======
0 ** 3128321638211 = 0

Number "0.00000000000001" (scale 0)
0.00000000000001 ** 0 = 1
0.00000000000001 ** -0 = 1
0.00000000000001 ** 1 = 0
0.00000000000001 ** 3128321638211 = 0

Number "-0.00000000000001" (scale 0)
-0.00000000000001 ** 0 = 1
-0.00000000000001 ** -0 = 1
-0.00000000000001 ** 1 = 0
-0.00000000000001 ** 3128321638211 = 0
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "0.00" (scale 10)
0.00 ** 0 = 1.0000000000
0.00 ** -0 = 1.0000000000
0.00 ** 1 = 0.0000000000
<<<<<<< HEAD
0.00 ** 1128321638 = 0.0000000000
=======
0.00 ** 3128321638211 = 0.0000000000
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "-0.00" (scale 10)
-0.00 ** 0 = 1.0000000000
-0.00 ** -0 = 1.0000000000
-0.00 ** 1 = 0.0000000000
<<<<<<< HEAD
-0.00 ** 1128321638 = 0.0000000000

Number "0.000000000000000000000000" (scale 10)
Expand All @@ -81,15 +114,38 @@ Number "-0.000000000000000000000000" (scale 10)
-0.000000000000000000000000 ** -0 = 1.0000000000
-0.000000000000000000000000 ** 1 = 0.0000000000
-0.000000000000000000000000 ** 1128321638 = 0.0000000000
=======
-0.00 ** 3128321638211 = 0.0000000000
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "-0" (scale 10)
-0 ** 0 = 1.0000000000
-0 ** -0 = 1.0000000000
-0 ** 1 = 0.0000000000
<<<<<<< HEAD
-0 ** 1128321638 = 0.0000000000
=======
-0 ** 3128321638211 = 0.0000000000
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)

Number "0" (scale 10)
0 ** 0 = 1.0000000000
0 ** -0 = 1.0000000000
0 ** 1 = 0.0000000000
<<<<<<< HEAD
0 ** 1128321638 = 0.0000000000
=======
0 ** 3128321638211 = 0.0000000000

Number "0.00000000000001" (scale 10)
0.00000000000001 ** 0 = 1.0000000000
0.00000000000001 ** -0 = 1.0000000000
0.00000000000001 ** 1 = 0.0000000000
0.00000000000001 ** 3128321638211 = 0.0000000000

Number "-0.00000000000001" (scale 10)
-0.00000000000001 ** 0 = 1.0000000000
-0.00000000000001 ** -0 = 1.0000000000
-0.00000000000001 ** 1 = 0.0000000000
-0.00000000000001 ** 3128321638211 = 0.0000000000
>>>>>>> dfdcd0c42e (Adjust bc_num to number without trailing zeros)