Avoid allocations when getting content of DOM nodes if possible #11543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everytime text content or node value or something alike is requested, it currently allocates memory twice: once in getting the data from libxml2, and then allocating a zend_string to copy the data into.
We can very often skip the first allocation. Let's do that because it's actually quite common to get the
textContent
for example from a node when processing documents.Here's a microbenchmark with time measurements (only for textContent, but for nodeValue etc the result is similar).
There's no noticeable slowdown because of the extra checks for the cases where we cannot avoid an allocation.
Based on these results I'd say it's worth it:
Bench results: