Fix GH-11520: Test fails due to compatibility issue with libzip 1.10.0 #11525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10.0 In libzip versions prior to 1.10.0, you couldn't do a read for a changed file: this would result in an error. This is tested in our .phpt test. Starting from version 1.10.0 [1] this is no longer an error. Therefore, we amend the test to check the behaviour depending on which version is used. [1] nih-at/libzip#286
|
I will dig on this I prefer if possible to not change the test but keep same behavior on all versions |
|
Looks changed files is primary api addition in 1.10 |
|
A slightly different fix was merged in |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libzip versions prior to 1.10.0, you couldn't do a read for a changed file: this would result in an error. This is tested in our .phpt test. Starting from version 1.10.0 [1] this is no longer an error. Therefore, we amend the test to check the behaviour depending on which version is used.
[1] nih-at/libzip#286
Closes GH-11520