Skip to content

Implement iteration cache, item cache and length cache for node list iteration #11330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 2, 2023
Merged

Implement iteration cache, item cache and length cache for node list iteration #11330

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0ff0ee3
Implement iteration cache, item cache and length cache for node list …
nielsdos May 29, 2023
02c0761
Use match any for ns too (note: contains bugfix for which I'll create…
nielsdos May 29, 2023
ff807d6
Update comment
nielsdos May 29, 2023
a75c85a
Comments
nielsdos May 29, 2023
dccd29c
Fix staleness check
nielsdos May 31, 2023
737f8be
Fix SimpleXML invalidations
nielsdos May 31, 2023
3e1eadf
Move common code, update internals upgrading note with the new functions
nielsdos May 31, 2023
6ca41b7
Add DOMDocument::xinclude() test for liveness
nielsdos May 31, 2023
57215ac
More invalidations
nielsdos May 31, 2023
8e614b3
Fix tree traversal and add some tests
nielsdos May 31, 2023
652c73a
Fixup extensions section
nielsdos May 31, 2023
4b69269
nodep == NULL is impossible here
nielsdos Jun 1, 2023
7ea0e02
Get rid of index == -1 condition
nielsdos Jun 1, 2023
c33dcd8
Improve test
nielsdos Jun 1, 2023
85da7e9
Add NULL check for detached document case
nielsdos Jun 1, 2023
39bee8b
Avoid allocations and rely on interned strings if possible
nielsdos Jun 1, 2023
efb4f45
Throw an exception instead
nielsdos Jun 2, 2023
8cba455
[ci skip] NEWS
nielsdos Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NULL check for detached document case
  • Loading branch information
@nielsdos
nielsdos committed Jun 1, 2023
commit 85da7e9c99884176bfd49e92eff6187b94b9137c
5 changes: 5 additions & 0 deletions ext/dom/php_dom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,11 @@ bool dom_has_feature(zend_string *feature, zend_string *version)

xmlNode *dom_get_elements_by_tag_name_ns_raw(xmlNodePtr basep, xmlNodePtr nodep, char *ns, char *local, int *cur, int index) /* {{{ */
{
/* Can happen with detached document */
if (UNEXPECTED(nodep == NULL)) {
return NULL;
}

xmlNodePtr ret = NULL;
bool local_match_any = local[0] == '*' && local[1] == '\0';

Expand Down