Skip to content

Access violation when ALLOC_FALLBACK fixed #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

KoudelkaB
Copy link
Contributor

@KoudelkaB KoudelkaB commented May 23, 2023

We had a problem with using opcache on the second php-cgi.exe (the fallback to file op cache on the second process was triggered by different load addresses of PHP8.dll in both processes - this was ok so far)
But the fallback to file opcache was not working - when the cache was accessed it caused ACCESS VIOLATION because of wrong opcache globals pointer.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KoudelkaB! Looks like an oversight. Can you please target/rebase onto the PHP-8.1 development branch?

@iluuu1994
Copy link
Member

Oh, and we also have the same issue here:

https://github.com/php/php-src/pull/11304/files#diff-8838190023fd4fbad393e08e4dddbac04ed7b1a37276be671d45076cf21086dfL218

Can you add it there as well? There other branches throw a fatal error and so are unproblematic.

@KoudelkaB KoudelkaB changed the base branch from PHP-8.2.6 to PHP-8.1 May 24, 2023 14:57
@KoudelkaB KoudelkaB changed the base branch from PHP-8.1 to PHP-8.2 May 24, 2023 14:58
@KoudelkaB KoudelkaB changed the base branch from PHP-8.2 to PHP-8.2.6 May 24, 2023 15:00
@KoudelkaB KoudelkaB deleted the branch php:PHP-8.2.6 May 24, 2023 15:14
@KoudelkaB KoudelkaB closed this May 24, 2023
@KoudelkaB KoudelkaB deleted the PHP-8.2.6 branch May 24, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants