Fix concat_function use-after-free on out-of-memory error#11297
Merged
Conversation
ndossche
approved these changes
May 22, 2023
ndossche
left a comment
Member
There was a problem hiding this comment.
Thanks for debugging and fixing this
dstogov
approved these changes
May 22, 2023
Member
Author
|
Actually, this worked: --TEST--
Bug #79836 (Segfault in concat_function)
--INI--
memory_limit=10M
--FILE--
<?php
class Foo {
public function __toString() {
return str_repeat('a', 10);
}
}
$i = str_repeat('a', 5 * 1024 * 1024);
$e = new Foo();
$e .= $i;
?>
--EXPECT--I will amend this test. |
iluuu1994
force-pushed
the
fix-string-concat-use-after-free
branch
2 times, most recently
from
May 22, 2023 17:52
c2b6034 to
1f44093
Compare
iluuu1994
force-pushed
the
fix-string-concat-use-after-free
branch
from
May 22, 2023 18:38
1f44093 to
b5d9825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by GH-10049
Unfortunately, I was not able to provide a test case for this. The example from 727e26f#commitcomment-114423406 only worked in the very specific case of keeping the file in the project root, and running it without run-tests.php.