Fix #9483: Fix autoconf warnings due to old libtool#11207
Merged
Conversation
ndossche
reviewed
May 9, 2023
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I only have limited libtool knowledge, but I think the changes are correct. I also tested them and it seems to work fine.
devnexen
approved these changes
May 10, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Is there a way to backport it to 8.2? |
Member
Author
We can, but we should then backport add also some others: #10383. |
Contributor
|
There's only 2? |
andypost
pushed a commit
to skilld-labs/php-src
that referenced
this pull request
May 19, 2023
Contributor
|
Filed #11279 |
Contributor
|
For PHP 8.1 I also using c68591f as patch |
Member
Author
|
Yes, I think these two are the only ones needed to remove the autoconf warnings. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.