Fix GH-11146: the use of SSE in the built-in webserver #11147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
requested changes
Apr 28, 2023
|
|
||
| if (*mimetype != NULL) { | ||
| if (*charset && strncmp(*mimetype, "text/", 5) == 0 && strstr(*mimetype, "charset=") == NULL) { | ||
| if (*charset && strncmp(*mimetype, "text/", 5) == 0 && strstr(*mimetype, "charset=") == NULL && strcmp(*mimetype, "text/event-stream") != 0) { |
There was a problem hiding this comment.
This will need to be more generic so we can use it for other subtypes that could be added as well.
There was a problem hiding this comment.
You can also start comparisons from subtype as text/ is already checked...
| $host = PHP_CLI_SERVER_HOSTNAME; | ||
|
|
||
| $fp = php_cli_server_connect(); | ||
| if(fwrite($fp, <<<HEADER |
There was a problem hiding this comment.
would be nice if you could define heredoc outside if to be more readable. Also there should be a space after if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11146