Skip to content

Fix GH-9356: Incomplete validation of IPv6 Address fields in subjectAltNames #11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Fix GH-9356: Incomplete validation of IPv6 Address fields in subjectAltNames #11145

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d10ba0
Fixed bug #9356 Incomplete validation of IP Address fields in subject…
lucasnetau Apr 28, 2023
70a523d
Conditionally include arpa/inet.h if detected
lucasnetau Apr 30, 2023
d38f3e0
Implement suggested expanded flag instead of checking strlen on each …
lucasnetau May 7, 2023
7da946e
snprintf buffer size includes the \0
lucasnetau May 7, 2023
d297059
CS: Space after comma
lucasnetau May 8, 2023
d445ec5
Skip test if IPv6 support is not available
lucasnetau May 9, 2023
0c6b7ca
Add News
lucasnetau May 9, 2023
4ab2146
Skip test when IPv6 is not enabled at compile time or when the CI spe…
lucasnetau May 9, 2023
002fdbb
Add additional SKIPIF test for IPv6 support on the host (copied from …
lucasnetau May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CS: Space after comma
  • Loading branch information
@lucasnetau
lucasnetau committed May 9, 2023
commit d297059d61886b331e0950354b6ce66731f5d548
2 changes: 1 addition & 1 deletion ext/openssl/xp_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ static bool php_openssl_matches_san_list(X509 *peer, const char *subject_name) /
unsigned char ipv6[16];
bool subject_name_is_ipv6 = false;
subject_name_ipv6_expanded[0] = 0;
if (inet_pton(AF_INET6,subject_name,&ipv6)) {
if (inet_pton(AF_INET6, subject_name, &ipv6)) {
EXPAND_IPV6_ADDRESS(subject_name_ipv6_expanded, ipv6);
subject_name_is_ipv6 = true;
}
Expand Down