Fix gmp_long/gmp_ulong typedef warning on Windows x86

[mvorisek]

extracted from #8479

discussed in #8479 (comment)

introduced in 08b732f

[mvorisek]

CI failure is unrelated

[Girgias]

Is this only happening on 64bits? because this change seems weird and it would make more sense to have an #if defined(PHP_WIN32) || defined(_WIN64)

[mvorisek]

Is this only happening on 64bits? because this change seems weird and it would make more sense to have an #if defined(PHP_WIN32) || defined(_WIN64)

yes, on x64 only, x86 need this PR/fix

[mvorisek]

@nielsdos can you please approve based on discussion in #8479 (comment)

[ndossche]

I'll take a look later this week with my Windows testing VM.

[ndossche]

I build this in my Windows VM for x86 and I think this looks right. Thanks. I do however think that targeting master is more appropriate: there seems to be an (unwritten?) rule that compiler warnings that don't cause bugs or errors should target master.

Is this only happening on 64bits? because this change seems weird and it would make more sense to have an #if defined(PHP_WIN32) || defined(_WIN64)

So here's something that always confused me too: PHP_WIN32 just means Windows (for BC reasons), it is set both on 32-bit and 64-bit. Want to detect Windows 64-bit? Then use _WIN64...
So this PR only changes the behaviour for 32-bit Windows.

[mvorisek]

Thank you for your post.

The PR is retargeted to master.

[ndossche]

Thanks!