FPM: refactor fpm_php_get_string_from_table() to better match usage#11051
Merged
Conversation
bukka
reviewed
Apr 10, 2023
bukka
reviewed
Apr 10, 2023
bukka
left a comment
bukka
left a comment
Member
There was a problem hiding this comment.
Looks reasonable - just some minor comments
Member
There was a problem hiding this comment.
I would rather leave this as a check as it's kind of external things from FPM PoV...
Pass in length of the key to improve the existance of the key check
Girgias
force-pushed
the
fpm-refactor-get-string-from-table
branch
from
April 11, 2023 10:43
3799dfa to
3360378
Compare
Member
Author
|
Addressed the review comments, only other change was to move the declaration of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in length of the key to improve the existance of the key check.
Feel free to close if you don't agree @bukka, but the returned
char*is never used and passing in the length of the key allows performing the quick check of "do both string lengths match".