FPM status page - JSON escape#11050
Closed
bukka wants to merge 2 commits into
Closed
Conversation
Girgias
approved these changes
Apr 10, 2023
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Looks sensible to me, just minor comments.
bukka
force-pushed
the
fpm_status_json_escape
branch
from
April 10, 2023 15:26
c915360 to
a34f93c
Compare
bukka
force-pushed
the
fpm_status_json_escape
branch
from
May 12, 2023 21:41
a34f93c to
78fb2fd
Compare
Girgias
approved these changes
May 13, 2023
Member
|
@bukka There were some failures in nightly in regards to this change. https://github.com/php/php-src/actions/runs/4969852729/jobs/8893356141 |
Contributor
|
This test constantly fails on Alpinelinux for all 32-bit arches (x86,armhf, armv7) TEST 16161/16323 [sapi/fpm/tests/bug64539-status-json-encoding.phpt]
========DIFF========
- string(5) "a=b"c"
+ string(0) ""
Done
========DONE========Ref https://gitlab.alpinelinux.org/andypost/aports/-/merge_requests/3#note_307466 |
Member
Author
|
I will check. |
iluuu1994
added a commit
that referenced
this pull request
May 17, 2023
Member
|
@bukka I marked the test as XFAIL for now, feel free to remove it whenever you have the time to have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bug #64539. It exposes the JSON string escape wrapped in the new API function
php_json_encode_string. That is then used in the status page for each query string.