Remove name field from the zend_constant struct #10954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As global constant names are case-sensitive now, we don't have to store them separately above the constant table.
kocsismate
force-pushed
the
remove-const-name
branch
from
64a8c83 to
a53db09
Compare
dstogov
requested changes
Mar 27, 2023
kocsismate
force-pushed
the
remove-const-name
branch
from
ad4f740 to
29e5ead
Compare
dstogov
reviewed
Mar 29, 2023
dstogov
reviewed
Mar 29, 2023
kocsismate
force-pushed
the
remove-const-name
branch
from
3a4ce5d to
0c64e89
Compare
kocsismate
commented
Mar 31, 2023
iluuu1994
reviewed
Mar 31, 2023
iluuu1994
reviewed
Mar 31, 2023
|
Finally, tests all pass :) So can I have a review round again? (I'll handle the UPGRADING.INTERNALS entry later) |
dstogov
reviewed
Apr 3, 2023
dstogov
approved these changes
Apr 3, 2023
kocsismate
added a commit
that referenced
this pull request
Jul 3, 2023
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jul 6, 2023
This reverts commit f42992f.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jul 17, 2023
This reverts commit f42992f.
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jul 17, 2023
This reverts commit f42992f. Closes phpGH-11604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As global constant names are case-sensitive now, we don't have to store them separately above the constant table keys.