ext/intl: dateformatter settimezone changes on success, returning true #10790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Mar 6, 2023
Girgias
reviewed
Mar 6, 2023
|
This is technically an API break, but the current API is so whack that I think it's fine... |
devnexen
force-pushed
the
intl_dateformat_upd
branch
from
3565411 to
97e6f3d
Compare
sure |
devnexen
force-pushed
the
intl_dateformat_upd
branch
3 times, most recently
from
d8ffc93 to
f6a8163
Compare
kocsismate
reviewed
Mar 7, 2023
devnexen
force-pushed
the
intl_dateformat_upd
branch
from
f6a8163 to
84b446d
Compare
kocsismate
reviewed
Mar 7, 2023
UPGRADING
Outdated
| . Changed DOMCharacterData::appendData() tentative return type to true. | ||
|
|
||
| - Intl: | ||
| . IntlDateformatter::setTimeZone (and its alias dafmt_set_timezone) |
There was a problem hiding this comment.
FYI: it's actually the other way around. dafmt_set_timezone has the implementation, and IntlDateformatter::setTimeZone is the alias. @alias foo is stubs basically mean that "this function/method is an alias of foo"
devnexen
force-pushed
the
intl_dateformat_upd
branch
from
84b446d to
f3fe321
Compare
kocsismate
reviewed
Mar 9, 2023
UPGRADING
Outdated
| . Changed DOMCharacterData::appendData() tentative return type to true. | ||
|
|
||
| - Intl: | ||
| . datefmT_set_timezone (and its alias IntlDateformatter::setTimeZone) |
There was a problem hiding this comment.
Suggested change
| . datefmT_set_timezone (and its alias IntlDateformatter::setTimeZone) | |
| . datefmt_set_timezone (and its alias IntlDateformatter::setTimeZone) |
devnexen
force-pushed
the
intl_dateformat_upd
branch
from
f3fe321 to
fc8b8a8
Compare
iluuu1994
reviewed
Mar 9, 2023
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| RETURN_TRUE; |
There was a problem hiding this comment.
Looks like an accidental unrelated change?
devnexen
force-pushed
the
intl_dateformat_upd
branch
from
fc8b8a8 to
5b05cb8
Compare
|
@iluuu1994 does it look ok now ? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like setcalendar.