sapi/fpm/status: replace variable-length array with emalloc() #10660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to @cmb69, PHP does not require VLA support (php#10304 (comment)). VLAs are a bad idea for several reasons, so let's get rid of them. This is a continuation of php#10645
devnexen
reviewed
Feb 22, 2023
| struct fpm_scoreboard_proc_s procs[scoreboard.nprocs]; | ||
| struct fpm_scoreboard_proc_s *procs = safe_emalloc(scoreboard.nprocs, sizeof(*procs), 0); | ||
| if (procs == NULL) { | ||
| return FAILURE; |
There was a problem hiding this comment.
I'd suggest not to mix "semantics", FAILURE is meant for zend_result type, like above, I would suggest to return just -1.
There was a problem hiding this comment.
What I have assumed here is that fpm_status_export_to_zval() is really supposed to return zend_result according to PHP's guidelines, but I have not yet submitted a PR that actually does this.
(It already returns the hard-coded integers, but not formally zend_result, but that's just a formal change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @cmb69, PHP does not require VLA support (#10304 (comment)). VLAs are a bad idea for several reasons, so let's get rid of them.
This is a continuation of #10645 (@bukka)