ext/json: add php_json_scanner_defs.h as make target #10032
Conversation
|
zend can fail in the same way so added that as a commit. Failure example: https://buildbot.mariadb.org/#/builders/237/builds/4281/steps/6/logs/stdio |
|
I wonder why that apparently doesn't fail elsewhere. What is special about this build system? |
possibly just a high -j parallel count. |
To prevent build failures like: make: *** No rule to make target '/code/master/ext/json/php_json_scanner_defs.h', needed by 'ext/json/json_scanner.lo'. Stop.
Its also attempting an out of source build. Which given the targets of this PR are generating files and putting them in the |
grooverdan
force-pushed
the
json_frag
branch
2 times, most recently
from
2169caf to
25b6e71
Compare
|
AFAIK, the PHP build system never lists headers as dependencies, so I'm not sure about this. Anyhow, if we do this, then we should also add the zend_language_scanner.c dependency for Windows: Line 93 in b6b4a62 |
like zend_ini_parser.h, list zend_ini_scanner_defs.h and zend_language_scanner_defs.h. Add all these files to generated_files so they don't get missed.
4 participants
To prevent build failures like:
make: *** No rule to make target '/code/master/ext/json/php_json_scanner_defs.h', needed by 'ext/json/json_scanner.lo'. Stop.
Example where this occurred is the 8.1 and master branches here: https://buildbot.mariadb.org/#/builders/237/builds/4280