Skip to content

mbstring: Do not stop when mbstring test faild #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

mbstring: Do not stop when mbstring test faild #10009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5051b2
mbstring: Do not stop when mbstring test faild
youkidearitai Nov 27, 2022
7c7571e
Set test faild counter.
youkidearitai Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 37 additions & 9 deletions ext/mbstring/tests/encoding_tests.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,26 @@
// Common code for tests which focus on conversion and verification of text
// in some specific encoding

// Test failed limit. If you execute all tests, set -1.
$testFailedLimit = 1000;
// Test failed counter
$testFailedCounter = 0;

// Count test failed. If test failed upper than $testFailedLimit, stop testing.
function testFailedIncrement() {
global $testFailedCounter, $testFailedLimit;

// $testFailedLimit is -1, no limit.
if ($testFailedLimit === -1)
return;

$testFailedCounter++;
if ($testFailedCounter < $testFailedLimit)
return;

die("=== Failed test " . $testFailedLimit . " times exceeded, stop testing ===");
}

// Read a file with one character and its equivalent Unicode codepoint on each
// line, delimited by tabs
function readConversionTable($path, &$from, &$to, $utf32 = false) {
Expand Down Expand Up @@ -51,27 +71,33 @@ function dbgPrint($str) {

function identifyValidString($goodString, $encoding) {
$result = mb_check_encoding($goodString, $encoding);
if (!$result)
die("mb_check_encoding failed on good $encoding string: " . dbgPrint($goodString));
if (!$result) {
echo "mb_check_encoding failed on good $encoding string: " . dbgPrint($goodString) . PHP_EOL;
testFailedIncrement();
}
}

function identifyInvalidString($badString, $encoding) {
$result = mb_check_encoding($badString, $encoding);
if ($result)
die("mb_check_encoding passed on bad $encoding string: " . dbgPrint($badString));
echo "mb_check_encoding passed on bad $encoding string: " . dbgPrint($badString) . PHP_EOL;
}

function testConversion($fromString, $toString, $fromEncoding, $toEncoding) {
$result = mb_convert_encoding($fromString, $toEncoding, $fromEncoding);
if ($result !== $toString)
die("mb_convert_encoding not working on $fromEncoding input: " . dbgPrint($fromString) . "\nExpected $toEncoding: " . dbgPrint($toString) . "\nActually got: " . dbgPrint($result));
if ($result !== $toString) {
echo "mb_convert_encoding not working on $fromEncoding input: " . dbgPrint($fromString) . "\nExpected $toEncoding: " . dbgPrint($toString) . "\nActually got: " . dbgPrint($result) . PHP_EOL;
testFailedIncrement();
}
}

function testValidConversion($fromString, $toString, $fromEncoding, $toEncoding) {
$illegalChars = mb_get_info('illegal_chars');
testConversion($fromString, $toString, $fromEncoding, $toEncoding);
if (mb_get_info('illegal_chars') !== $illegalChars)
die("mb_convert_encoding incremented illegal_chars on valid $fromEncoding string: " . dbgPrint($fromString) . " when converting to $toEncoding");
if (mb_get_info('illegal_chars') !== $illegalChars) {
echo "mb_convert_encoding incremented illegal_chars on valid $fromEncoding string: " . dbgPrint($fromString) . " when converting to $toEncoding" . PHP_EOL;
testFailedIncrement();
}
}

function convertValidString($fromString, $toString, $fromEncoding, $toEncoding, $bothWays = true) {
Expand All @@ -83,8 +109,10 @@ function convertValidString($fromString, $toString, $fromEncoding, $toEncoding,
function convertInvalidString($fromString, $toString, $fromEncoding, $toEncoding) {
$illegalChars = mb_get_info('illegal_chars');
testConversion($fromString, $toString, $fromEncoding, $toEncoding);
if (mb_get_info('illegal_chars') <= $illegalChars)
die("mb_convert_encoding did not increment illegal_chars on invalid $fromEncoding string: " . dbgPrint($fromString) . " when converting to $toEncoding");
if (mb_get_info('illegal_chars') <= $illegalChars) {
echo "mb_convert_encoding did not increment illegal_chars on invalid $fromEncoding string: " . dbgPrint($fromString) . " when converting to $toEncoding" . PHP_EOL;
testFailedIncrement();
}
}

function testValidString($fromString, $toString, $fromEncoding, $toEncoding, $bothWays = true) {
Expand Down