PGO build fails with xxhash

[nisbet-hubbard]

Description

The following code:

make prof-gen
…
make prof-clean
make prof-use

Resulted in this output:

/bin/sh /tmp/php-8.3.8/libtool --silent --preserve-dup-deps --tag=CC --mode=compile cc -Iext/hash/ -I/tmp/php-8.3.8/ext/hash/ -I/tmp/ph
p-8.3.8/include -I/tmp/php-8.3.8/main -I/tmp/php-8.3.8 -I/tmp/php-8.3.8/ext/date/lib -I/usr/include/libxml2 -I/usr/include/libpng16 -I/
tmp/php-8.3.8/ext/mbstring/libmbfl -I/tmp/php-8.3.8/ext/mbstring/libmbfl/mbfl -I/tmp/php-8.3.8/TSRM -I/tmp/php-8.3.8/Zend  -D_GNU_SOURC
E  -fno-common -Wstrict-prototypes -Wformat-truncation -Wlogical-op -Wduplicated-cond -Wno-clobbered -Wall -Wextra -Wno-unused-paramete
r -Wno-sign-compare -O2 -march=native -ffp-contract=off -fvisibility=hidden -Wimplicit-fallthrough=1 -DZEND_SIGNALS -fprofile-use  -Wno
-implicit-fallthrough -I/tmp/php-8.3.8/ext/hash/sha3/generic64lc -DKeccakP200_excluded -DKeccakP400_excluded -DKeccakP800_excluded -DZE
ND_ENABLE_STATIC_TSRMLS_CACHE=1 -I/tmp/php-8.3.8/ext/hash/xxhash -c /tmp/php-8.3.8/ext/hash/hash_xxhash.c -o ext/hash/hash_xxhash.lo  -
MMD -MF ext/hash/hash_xxhash.dep -MT ext/hash/hash_xxhash.lo                                                                           
/tmp/php-8.3.8/ext/hash/hash_xxhash.c: In function ‘PHP_XXH3_128_Copy’:                                                                
/tmp/php-8.3.8/ext/hash/hash_xxhash.c:267:1: warning: ‘/tmp/php-8.3.8/ext/hash/.libs/hash_xxhash.gcda’ profile count data file not foun
d [-Wmissing-profile]                                                                                                                  
  267 | }                                                                                                                              
      | ^                                                                                                                              
make[1]: *** [Makefile:1396: ext/hash/hash_xxhash.lo] Error 1                                                                          
make[1]: Leaving directory '/tmp/php-8.3.8'                                                                                            
make: *** [Makefile:288: prof-use] Error 2

The error doesn’t appear with GCC11.

PHP Version

PHP 8.3.8

Operating System

RHEL 9

[nielsdos]

I don't really get what the bug/issue is. You're cleaning the profile data with prof-clean, so of course it doesn't find the necessary file?

[nisbet-hubbard]

Oh, the abort wasn't caused by that warning. There's quite a number of these, but they don't affect make. There's a bugzilla ticket that explains why these warnings are there.

The issue is about compiler incompatibility. I was able to compile just fine with GCC11 (with all those warnings present), but not with GCC13.

[nielsdos]

Can you please post the error that causes the abort?

[nisbet-hubbard]

This is all that the compiler emitted:

make[1]: *** [Makefile:1396: ext/hash/hash_xxhash.lo] Error 1                                                                          
make[1]: Leaving directory '/tmp/php-8.3.8'                                                                                            
make: *** [Makefile:288: prof-use] Error 2

Although it follows on the heels of the warning, the error apparently has nothing to do with the warning since GCC11 compiled fine despite the warning. And other similar warnings didn't lead to failure in 13.