Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 033eec7
Choose a base ref
...
head repository: php/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 55e7000
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Oct 17, 2024

  1. Reflection: show the type of object constants used as default properties 

    When a property default is based on a global constant, show the type of the
default. Previously, `format_default_value()` assumed that non-scalar and
non-array defaults were always going to be `IS_CONSTANT_AST` pointers, and when
the AST expression had been evaluated and produced an object, depending on when
the `ReflectionClass` or `ReflectionProperty` instance had been created, the
default was shown as one of `callable`, `__CLASS__`, or `...`.

Instead, if the default value is an object (`IS_OBJECT`), show the type of that
object.

Add test cases for each of the `callable`, `__CLASS__`, and `...` cases to
confirm that they all now properly show the type of the constant.

Closes gh-15902
    @DanielEScherzer @iluuu1994
    DanielEScherzer authored and iluuu1994 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    55e7000 View commit details
    Browse the repository at this point in the history
Loading