Separate regular PhD output from error handling #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move error handling code into a class and remove PhD message output handling from it. Introduce a new class to handle PhD message output. Make the implicit dependency on the output functionality of classes explicit. Update PEAR package.xml. Fix tests.
Girgias
reviewed
Nov 4, 2024
Comment on lines
27
to
32
| if (\LIBXML_VERSION >= 20620) { | ||
| return self::readString(); | ||
| } | ||
| v("You are using libxml2 v%d, but v20620 or newer is preferred", \LIBXML_VERSION, VERBOSE_OLD_LIBXML); | ||
| $this->outputHandler->v("You are using libxml2 v%d, but v20620 or newer is preferred", \LIBXML_VERSION, VERBOSE_OLD_LIBXML); | ||
|
|
||
| $node = $this->name; |
Member
There was a problem hiding this comment.
Aside, how old/recent is this version? Might make sense to drop this in a follow-up.
Contributor
Author
There was a problem hiding this comment.
It's from July of 2005. :-)
added 7 commits
November 9, 2024 17:54
Girgias
approved these changes
Nov 9, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Minor final comment, but LGTM thank you!
Contributor
Author
|
Test failure is PHP 8.0 tests failing due the first-class callable syntax. We already had Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move error handling code into a class and remove PhD message output handling from it.
Introduce a new class to handle PhD message output.
Make the implicit dependency on the output functionality of classes explicit.
Update PEAR package.xml.
Fix tests.