Add links to constants with replaceable tags #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add links to constants with replaceable tags by processing them when the constant tag is being closed. Add a test.
Girgias
pushed a commit
to php/doc-en
that referenced
this pull request
Nov 3, 2024
This will link to the constant pages since php/phd#175 has been marged. Co-authored-by: haszi <haszika80@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links to constants with replaceable tags by processing them when the constant tag is being closed. Also add a test.
This currently only works with one set of
<replaceable>tags per constant (due to issues making the regex non-greedy). In practice, this shouldn't be an issue as we have no constants with more than one set of these tags.The implementation feels a little hacky but more or less matches the processing of all other tags where post-processing is needed (all the class-based
synposis*tags and their children).