Conversation
|
Thinking about adding german or italian docs, so I can also give a LGMT 😅 |
|
Yes, yes I absolutely speal all (or any) of the translated languages 😄 It looks fine in structure, the rest we can't really verify anyhow. I've thought about adding German, but I know myself well-enough that I wouldn't maintain it. |
|
I tried generating the German docs locally. The translations look largely fine to me. It's a bit weird sometimes on technical terms and literal translations of English phrases, but it's worlds better than no or outdated docs. |
There was a problem hiding this comment.
Pull request overview
Adds localized documentation pages for “Extension Workers” and normalizes a formatting issue in existing translated config docs.
Changes:
- Add new translated
extension-workers.mdpages for TR/RU/PT-BR/JA/FR/CN. - Fix the first-line header formatting in
docs/tr/config.mdanddocs/ru/config.md(removes an odd leading character / restores normal heading).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tr/extension-workers.md | New Turkish translation of Extension Workers documentation |
| docs/tr/config.md | Normalizes the top-level heading formatting |
| docs/ru/extension-workers.md | New Russian translation of Extension Workers documentation |
| docs/ru/config.md | Normalizes the top-level heading formatting |
| docs/pt-br/extension-workers.md | New Brazilian Portuguese translation of Extension Workers documentation |
| docs/ja/extension-workers.md | New Japanese translation of Extension Workers documentation |
| docs/fr/extension-workers.md | New French translation of Extension Workers documentation |
| docs/cn/extension-workers.md | New Chinese translation of Extension Workers documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // 服务器启动（全局） | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("扩展：服务器正在启动...") | ||
| }), | ||
|
|
||
| // 线程就绪（每线程） | ||
| // 注意：此函数接受一个表示线程 ID 的整数 | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("扩展：Worker 线程 #%d 已就绪。\n", id) | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // Sunucu Başlatma (Genel) | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("Uzantı: Sunucu başlıyor...") | ||
| }), | ||
|
|
||
| // İş Parçacığı Hazır (İş Parçacığı Başına) | ||
| // Not: Fonksiyon, İş Parçacığı Kimliğini temsil eden bir tamsayı kabul eder | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("Uzantı: İşçi iş parçacığı #%d hazır.\n", id) | ||
| }), | ||
| ) |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // Запуск сервера (Глобальный) | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("Extension: Server starting up...") | ||
| }), | ||
|
|
||
| // Поток готов (Для каждого потока) | ||
| // Примечание: Функция принимает целое число, представляющее ID потока | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("Extension: Worker thread #%d is ready.\n", id) | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // Inicialização do Servidor (Global) | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("Extensão: Servidor iniciando...") | ||
| }), | ||
|
|
||
| // Thread Pronta (Por Thread) | ||
| // Nota: A função aceita um inteiro representando o ID do Thread | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("Extensão: Thread worker #%d está pronta.\n", id) | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // サーバー起動時 (グローバル) | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("Extension: Server starting up...") | ||
| }), | ||
|
|
||
| // スレッド準備完了時 (スレッドごと) | ||
| // 注: この関数はスレッドIDを表す整数を受け入れます | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("Extension: Worker thread #%d is ready.\n", id) | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
| func init() { | ||
| workerHandle = frankenphpCaddy.RegisterWorkers( | ||
| "my-worker", "worker.php", 2, | ||
|
|
||
| // Démarrage du Serveur (Global) | ||
| frankenphp.WithWorkerOnServerStartup(func() { | ||
| fmt.Println("Extension : Démarrage du serveur...") | ||
| }), | ||
|
|
||
| // Thread Prêt (Par Thread) | ||
| // Note : La fonction accepte un entier représentant l'ID du Thread | ||
| frankenphp.WithWorkerOnReady(func(id int) { | ||
| fmt.Printf("Extension : Le thread worker #%d est prêt.\n", id) | ||
| }), | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this example, workerHandle is assigned but not declared anywhere in the snippet, while earlier examples use the global worker variable. This makes the example inconsistent and non-compilable as written; either declare workerHandle (with the correct type) or reuse the existing worker handle consistently.
Translation updates for: extension-workers.md .