Conversation
| ```console | ||
| docker run \ | ||
| -e FRANKENPHP_CONFIG="worker /app/caminho/para/seu/worker/script.php" \ | ||
| -e FRANKENPHP_CONFIG="worker /app/path/to/your/worker/script.php" \ |
There was a problem hiding this comment.
this is correct based on our prompts, but how do we feel about this?
There was a problem hiding this comment.
Maybe the prompt should not allow it to un-translate already translated stuff. Or we can also tell it to adjust code translations based on what's done in the existing translations.
There was a problem hiding this comment.
I actually don't think it's a terrible idea to have it behave this way. It also simplifies cases of e.g. french characters that aren't valid file paths. Or chinese.
There was a problem hiding this comment.
Don't think it would actually add invalid characters to paths. I guess I still agree with you though since code is just generally written in english, so knowning what /path/to/app means is probably the required minimum.
There was a problem hiding this comment.
Pull request overview
This PR updates translations for the worker documentation across multiple languages (Turkish, Russian, Portuguese, Japanese, French, and Chinese). The updates synchronize the translated documentation with recent changes to the English version, including new features and best practices.
Changes:
- Added documentation for worker restart capabilities via file watching and manual API calls
- Included Symfony 7.4 tip about native FrankenPHP worker mode support
- Updated worker script examples to include try-catch exception handling
- Removed deprecated
ignore_user_abort(true)from code examples - Fixed BOM (Byte Order Mark) characters in Turkish and Russian config files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tr/worker.md | Updated Turkish translation with new worker features, exception handling patterns, and configuration options |
| docs/tr/config.md | Removed BOM character from file header |
| docs/ru/worker.md | Updated Russian translation with new worker features, exception handling patterns, and configuration options |
| docs/ru/config.md | Removed BOM character from file header |
| docs/pt-br/worker.md | Updated Portuguese (Brazil) translation with new worker features and simplified text formatting |
| docs/ja/worker.md | Updated Japanese translation with new worker features and hot reload information |
| docs/fr/worker.md | Updated French translation with new worker features and removed experimental note |
| docs/cn/worker.md | Updated Chinese translation with new worker features and exception handling patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
Translation updates for: worker.md .