extgen: Add support for init/minit/mshutdown#1786
extgen: Add support for init/minit/mshutdown#1786withinboredom wants to merge 14 commits intomainfrom
Conversation
c036230 to
3d9d672
Compare
|
My last commit breaks classes, but is needed for functions-only extensions. I'll need to make that import conditional on whether or not there are classes present and add a test for it. |
|
This one is probably ready for review now @dunglas |
|
This is really nice and certainly useful. Thanks! Bikeshedding: should we call the directives |
alexandre-daubois
left a comment
There was a problem hiding this comment.
I didn't see a test for this: what happens if these new directives are called multiple times in the same file?
If you want an example, we already limited //export_php:namespace to one per file
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
This reverts commit 3d9d672.
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Signed-off-by: Robert Landers <landers.robert@gmail.com>
7cd7983 to
1231110
Compare
alexandre-daubois
left a comment
There was a problem hiding this comment.
Works for me, thanks for adding the duplicated directive checks!
This PR adjusts extgen to handle:
init()function.//export_php:module initto handle resource creation during module startup//export_php:module shutdownto handle resource cleanup during module shutdown