clarify response type for Memcached::deleteMulti #853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the documentation does not clearly say that response codes will be returned, although the implementation does exactly that. - see https://github.com/php-memcached-dev/php-memcached/blob/605a8a63a7461983512ce12601e995dad18f5a9b/php_memcached.c#L2278-L2282
|
I think a few problems still remain after this commit, so I made #1957 as an alternative. |
|
@tstarling Did I correctly understand that #1957 makes this PR no longer relevant, and therefore can be closed? |
|
Yes, the issue was addressed in #1957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codes will be returned, although the implementation
does exactly that.