The fallback for undefined constants is removed as of PHP 8 #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilina
requested changes
Aug 5, 2021
language/types/array.xml
Outdated
Comment on lines
620
to
622
| The fallback to treat an undefined constant as bare string is removed | ||
| as of PHP 8.0.0 and throws <classname>Error</classname> exception. | ||
| It has been deprecated as of PHP 7.2.0, and issues an error of level <constant>E_WARNING</constant>. |
There was a problem hiding this comment.
- Follow chronological order
- Past tense for both versions
Suggested change
| The fallback to treat an undefined constant as bare string is removed | |
| as of PHP 8.0.0 and throws <classname>Error</classname> exception. | |
| It has been deprecated as of PHP 7.2.0, and issues an error of level <constant>E_WARNING</constant>. | |
| The fallback to treat an undefined constant as bare string has been deprecated | |
| as of PHP 7.2.0, and issues an error of level <constant>E_WARNING</constant>. | |
| As of PHP 8.0.0, it has been removed and throws an <classname>Error</classname> exception. |
There was a problem hiding this comment.
Thanks. This is a good catch. I did it in this order because that is how it was written before (see the last line about E_NOTICE). I think I have to rewrite the whole paragraph now, so it makes sense.
|
@afilina I followed your suggestion. Does it look better now? |
afilina
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.