Repository navigation
docs: document ftp_append behavior and parameters - #5917
Merged
Merged
Conversation
lacatoire
approved these changes
Oct 6, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I documented
ftp_append()inreference/ftp/functions/ftp-append.xml: it uploads the contents of a local file and appends them to the remote file instead of overwriting it. I also filled in the remote path, local source path, and transfer mode descriptions, and removed the undocumented-function warning.Fixes #5786 for the
ftp_append()page only. I have left the other pages in that tracking issue unchanged.Validation
I checked the behavior against
ext/ftp/php_ftp.candext/ftp/ftp.c. On PHP 8.5.11, I also ran a local FTP integration probe covering default and explicit binary transfers, preservation of existing remote contents, unchanged local contents, ASCII transfer, and failure for a missing local source. All ten assertions passed.Using a local PHP 8.5.11 CLI wrapper, I ran:
php ../docbook-cs/bin/docbook-cs reference/ftp/functions/ftp-append.xml --no-colors— no violations.php ../doc-base/configure.php --with-php=/path/to/local/php --disable-libxml-check --enable-xml-details --redirect-stderr-to-stdout --with-lang=en— the complete English manual XML build and Jing validation passed.php ../doc-base/scripts/qa/extensions.xml.php --check— passed, with no resulting source changes.php ../doc-base/scripts/qa/section-order.php— no files with issues.git diff --check— passed.I did not run PhD HTML rendering.