[PHP 8.4] Update ext-mbstring
#4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 4, 2024
Comment on lines
77
to
78
| <exceptionname>ValueError</exceptionname> if the <parameter>encoding</parameter> | ||
| parameter contains null bytes. |
There was a problem hiding this comment.
To be symetric to the other changelog
Suggested change
| <exceptionname>ValueError</exceptionname> if the <parameter>encoding</parameter> | |
| parameter contains null bytes. | |
| <exceptionname>ValueError</exceptionname> if <parameter>encoding</parameter> | |
| contains null bytes. |
Comment on lines
75
to
76
| Throws a <exceptionname>ValueError</exceptionname> if | ||
| <parameter>map</parameter> doesn't contain integers only. |
There was a problem hiding this comment.
Maybe?
Suggested change
| Throws a <exceptionname>ValueError</exceptionname> if | |
| <parameter>map</parameter> doesn't contain integers only. | |
| Throws a <exceptionname>ValueError</exceptionname> if | |
| <parameter>map</parameter> is not a list of ℤ. |
(and apply elsewhere)
alexandre-daubois
force-pushed
the
mb-string-84
branch
2 times, most recently
from
e23d268 to
dfdd2df
Compare
alexandre-daubois
force-pushed
the
mb-string-84
branch
from
dfdd2df to
8898163
Compare
|
Should be better now |
Girgias
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3872