PHP 8.4: New XML{Reader,Writer} methods #4138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
force-pushed
the
xml-reader-writer-84-methods
branch
from
f6b22f9 to
52e17d1
Compare
ndossche
force-pushed
the
xml-reader-writer-84-methods
branch
2 times, most recently
from
fe7a8f9 to
aba89a2
Compare
Girgias
requested changes
Nov 24, 2024
Comment on lines
+19
to
+23
| <refsect1 role="parameters"> | ||
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('xmlwriter.openuri')/db:refsect1[@role='parameters']/*)"> | ||
| <xi:fallback/> | ||
| </xi:include> | ||
| </refsect1> |
There was a problem hiding this comment.
I feel I need to change the section_check QA script so that
Suggested change
| <refsect1 role="parameters"> | |
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('xmlwriter.openuri')/db:refsect1[@role='parameters']/*)"> | |
| <xi:fallback/> | |
| </xi:include> | |
| </refsect1> | |
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('xmlwriter.openuri')/db:refsect1[@role='parameters']/.)"> | |
| <xi:fallback/> | |
| </xi:include> |
doesn't fail the CI.
There was a problem hiding this comment.
Yeah I had this first but indeed changed it. Ideally the QA script probably should run after xinclude processing?
There was a problem hiding this comment.
The thing is the QA script is "dumb" and does text processing on the file content, no XML parsing or XInclude can actually happen :/
There was a problem hiding this comment.
Oh okay, I didn't know that.
The approach we have to take to make it happy isn't too bad, just a bit unfortunate, so it's not really that important to fix I'd say.
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Girgias
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.