Fix GH-1408: Deprecation of libxml_disable_entity_loader() should warn about constants which will override the new default behaviour #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warn about constants which will override the new default behaviour Based on stale PR phpGH-1409. Closes phpGH-1409. Closes phpGH-1408. Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
Girgias
requested changes
Nov 11, 2024
reference/libxml/constants.xml
Outdated
| <caution> | ||
| <simpara> | ||
| Enabling loading of DTD attributes will enable fetching of external entities. | ||
| The <link linkend="constant.libxml-no-xxe"><constant>LIBXML_NO_XXE</constant></link> constant can be used to prevent this (only available in Libxml >= 2.13.0, as of PHP 8.4.0). |
There was a problem hiding this comment.
Linking is automatic now
Suggested change
| The <link linkend="constant.libxml-no-xxe"><constant>LIBXML_NO_XXE</constant></link> constant can be used to prevent this (only available in Libxml >= 2.13.0, as of PHP 8.4.0). | |
| The <constant>LIBXML_NO_XXE</constant> constant can be used to prevent this (only available in Libxml >= 2.13.0, as of PHP 8.4.0). |
reference/libxml/constants.xml
Outdated
| <caution> | ||
| <simpara> | ||
| Enabling loading of external subsets will enable fetching of external entities. | ||
| The <link linkend="constant.libxml-no-xxe"><constant>LIBXML_NO_XXE</constant></link> constant can be used to prevent this (only available in Libxml >= 2.13.0, as of PHP 8.4.0). |
reference/libxml/constants.xml
Outdated
| @@ -71,6 +83,7 @@ | |||
| <caution> | |||
| <simpara> | |||
| Enabling validating the DTD may facilitate XML External Entity (XXE) attacks. | |||
| The <link linkend="constant.libxml-no-xxe"><constant>LIBXML_NO_XXE</constant></link> constant can be used to prevent this (only available in Libxml >= 2.13.0, as of PHP 8.4.0). | |||
| Generally, it is preferable to use <function>libxml_set_external_entity_loader</function> | ||
| to suppress loading of external entities. | ||
| The <link linkend="constant.libxml-no-xxe"><constant>LIBXML_NO_XXE</constant></link> constant can be used to prevent this as well (only available in Libxml >= 2.13.0, as of PHP 8.4.0). |
Comment on lines
107
to
109
| <member><link linkend="libxml.constants">The <constant>LIBXML_NOENT</constant> constant</link></member> | ||
| <member><link linkend="libxml.constants">The <constant>LIBXML_DTDVALID</constant> constant</link></member> | ||
| <member><link linkend="libxml.constants">The <constant>LIBXML_NO_XXE</constant> constant</link></member> |
There was a problem hiding this comment.
Does link tags are unnecessary now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on stale PR GH-1409.
Closes GH-1409.
Closes GH-1408.