Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-auth.xml: remove mention of digest #3625

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

mmalferov
Copy link
Member

Digest HTTP Authentication example has been removed, but the mention of the content of the deleted paragraph remains

Digest HTTP Authentication example has been removed, but the mention of the content of the deleted paragraph remains
Comment on lines 53 to +54
<emphasis>HTTP/1.0 401</emphasis> header line. Authentication parameters have
to be comma-separated as seen in the digest example above.
to be comma-separated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I'm not sure if the whole sentence should be removed; I believe basic authentication has no further parameters than realm. Mabye @jimwins knows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I think it would be safe to remove the whole sentence.

@jimwins jimwins merged commit bdf9a4e into php:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants