Fixed formats and example for localized notations under compound formats #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
requested changes
Jun 24, 2024
| @@ -784,7 +784,7 @@ object(DateTimeImmutable)#1 (3) { | |||
| <tbody> | |||
| <row> | |||
| <entry>Common Log Format</entry> | |||
| <entry><literal>dd</literal> "/" <literal>M</literal> "/" <literal>YY</literal> : <literal>HH</literal> ":" <literal>II</literal> ":" <literal>SS</literal> <literal>space</literal> <literal>tzcorrection</literal></entry> | |||
| <entry><literal>DD</literal> "/" <literal>M</literal> "/" <literal>YY</literal> ":" <literal>HH</literal> ":" <literal>II</literal> ":" <literal>SS</literal> <literal>space</literal> <literal>tzcorrection</literal></entry> | |||
There was a problem hiding this comment.
Adding " around : is correct, but changing DD to dd is not. The parsing rule has:
/* Common Log Format: 10/Oct/2000:13:55:36 -0700 */
clf = day "/" monthabbr "/" year4 ":" hour24lz ":" minutelz ":" secondlz space tzcorrection;
With day defined as:
day = (([0-2]?[0-9]) | ("3"[01])) daysuf?;
the dd and mm rules are however missing in the table here (whereas DD and MM are included). These rows needs to be copied from the table for "Date Formats (https://www.php.net/manual/en/datetime.formats.php#datetime.formats.date)".
| <entry><literal>YY</literal> "-" <literal>mm</literal> "-" <literal>dd</literal> "T" <literal>hh</literal> ":" <literal>ii</literal> ":" <literal>ss</literal></entry> | ||
| <entry>"2008-7-1T9:3:37"</entry> | ||
| <entry><literal>YY</literal> "-" <literal>MM</literal> "-" <literal>DD</literal> "T" <literal>hh</literal> ":" <literal>ii</literal> ":" <literal>ss</literal></entry> | ||
| <entry>"2008-07-01T09:03:37"</entry> |
There was a problem hiding this comment.
This is not a correct change. mm and dd mean either one or two digits, where MM and DD format as leading-0 strings.
The parsing rule in parse_date.re is:
wddx = year4 "-" month "-" day "T" hour24 ":" minute ":" second;
with month and day specified as:
month = "0"? [0-9] | "1"[0-2];
day = (([0-2]?[0-9]) | ("3"[01])) daysuf?;
Please remember that these are rules to parse these formats, and not output formats (there are no WDDX and CLF constants).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.