Add avif to gd installation instructions #3058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jan 3, 2024
Comment on lines
+42
to
+43
| To enable support for avif add | ||
| <option role="configure">--with-avif</option>. |
There was a problem hiding this comment.
Does this accept a directory like some of the other options or not?
There was a problem hiding this comment.
I'm not entirely sure, but I think not, given that the =DIR variants for all other formats have been replaced as of PHP 7.4.0, so I doubt that it has ever been added for this one.
For reference, the implementation PR can be found at php/php-src#7026.
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it slightly easier to find and recognise as an option.
Also add avif and webp to the list with supported types for reference. Note that this might require additional details (e.g. link to library) if that is preferred.