-
Notifications
You must be signed in to change notification settings - Fork 801
Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2561927
to
321a4ec
Compare
321a4ec
to
cb1e77e
Compare
Duplicate of #2813? |
Nope, fortunately this one synchronizes the class synopses. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for @nielsdos to comment about the descriptions but looks good to me otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this Máté!
I have some remarks and description suggestions 🙂
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
f74fda4
to
8ab84b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Most descriptions are empty, so I'm happy to receive suggestions :)