Skip to content

Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Oct 28, 2023

Most descriptions are empty, so I'm happy to receive suggestions :)

@TimWolla
Copy link
Member

Duplicate of #2813?

@kocsismate
Copy link
Member Author

Nope, fortunately this one synchronizes the class synopses. 🙂

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @nielsdos to comment about the descriptions but looks good to me otherwise

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this Máté!
I have some remarks and description suggestions 🙂

kocsismate and others added 3 commits October 29, 2023 10:59
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
@kocsismate kocsismate changed the title Synchronize ext/dom with the stubs based on the PHP 8.3 changes Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes Oct 29, 2023
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Girgias Girgias merged commit fa6a582 into php:master Oct 29, 2023
@kocsismate kocsismate deleted the stub-sync-dom branch October 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants